fix: Return error if no tx inputs provided in submit_proven_transaction#1852
Merged
fix: Return error if no tx inputs provided in submit_proven_transaction#1852
Conversation
sergerad
added
the
no changelog
sergerad
requested review from
Mirko-von-Leipzig and
bobbinth
and removed request for
bobbinth
igamigo
approved these changes
Mar 27, 2026
Collaborator
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! In the client this is enforced at the RPC trait level, so there should be no problem.
async fn submit_proven_transaction(
&self,
proven_transaction: ProvenTransaction,
transaction_inputs: TransactionInputs,
) -> Result<BlockNumber, RpcError>;
Comment on lines
+419
to
+420
| } else { | ||
| return Err(Status::invalid_argument("Transaction inputs must be provided")); |
Collaborator
There was a problem hiding this comment.
fyi this can be written as
let request = request.transaction_inputs.ok_or(Err(...))?;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1850.